fs: improve error performance of fchownSync
#49920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
anonrig
approved these changes
Sep 28, 2023
github-actions
bot
removed
the
request-ci
anonrig
added
the
performance
|
Fixed error by moving validation back to |
31 tasks
|
Hey @evelez7, can you handle the conflicts? You'll see that |
evelez7
force-pushed
the
perf-fchownSync
branch
from
77696fa
to
8a4d9f3
Compare
|
@evelez7 Your changes include the fs/sync.js file. Can you remove it? |
Sorry about that, thought it was removed in the rebase. |
16 tasks
joyeecheung
reviewed
Oct 6, 2023
| try { | ||
| return fs.openSync(x, 'r'); | ||
| } catch { | ||
| return 1 << 30; |
There was a problem hiding this comment.
Shouldn't this only be part of the non-existing case?
| int err = uv_fs_fchown(nullptr, &req, fd, uid, gid, nullptr); | ||
| FS_SYNC_TRACE_END(fchown); | ||
| if (err < 0) { | ||
| return env->ThrowUVException(err, "fchown"); |
There was a problem hiding this comment.
This does not need a new binding, it can just be done by switching SyncCall to SyncCallAndThrowOnError in the original FChownSync implementation.
|
This needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @CanadaHonk for the benchmark using file descriptors.
Ref: nodejs/performance#106