This repository was archived by the owner on Apr 16, 2020. It is now read-only.
-m alias for --type=module #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
968c8f1 to
0dbed6b
Compare
guybedford
approved these changes
Feb 17, 2019
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Thanks for working on this.
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
0dbed6b to
621a632
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
621a632 to
d89e9ee
Compare
MylesBorins
force-pushed
the
modules-lkgr
branch
from
d89e9ee to
22339db
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
22339db to
f513752
Compare
GeoffreyBooth
force-pushed
the
m-flag
branch
from
b9d830e to
9359a1b
Compare
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Myles Borins <MylesBorins@google.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/modules#180 PR-URL: nodejs#6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#6 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <mylesborins@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
f513752 to
4d734bb
Compare
GeoffreyBooth
force-pushed
the
m-flag
branch
from
9359a1b to
bbb39b6
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
2 times, most recently
from
b84c079 to
a4955e2
Compare
nodejs-ci
force-pushed
the
modules-lkgr
branch
from
a4955e2 to
7c92011
Compare
hybrist
approved these changes
Feb 27, 2019
Contributor
|
I'm not so into |
Contributor
|
Consensus in meeting that we can land |
Member
Author
|
Closing in favor of #45 which includes this same code and was also approved in the meeting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-malias for--type=module. Was missing from #32 despite being added to the docs in that PR.I’m new to the codebase so feedback very welcome.