Skip to content

feat(test): validate commands and generators #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Conversation

avivkeller
Copy link
Member

Follow-up #315: Prevents that from happening in the future by validating the command objects as a test.

@Copilot Copilot AI review requested due to automatic review settings June 22, 2025 20:10
@avivkeller avivkeller requested a review from a team as a code owner June 22, 2025 20:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.81%. Comparing base (f26013f) to head (cf75f5a).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #317       +/-   ##
===========================================
+ Coverage   49.39%   65.81%   +16.41%     
===========================================
  Files          80       80               
  Lines        6818     6818               
  Branches      281      316       +35     
===========================================
+ Hits         3368     4487     +1119     
+ Misses       3447     2328     -1119     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller changed the title feat(test): validate commands feat(test): validate commands and generators Jun 22, 2025
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@ovflowd
Copy link
Member

ovflowd commented Jun 23, 2025

Feel free to fast-track if needed.

@avivkeller
Copy link
Member Author

I don't see a need to, it's not urgent

@AugustinMauroy
Copy link
Member

FYI this repo doesn't require any time before merging
https://github.com/nodejs/api-docs-tooling/blob/main/CONTRIBUTING.md#submitting-your-changes

@ovflowd
Copy link
Member

ovflowd commented Jun 23, 2025

FYI this repo doesn't require any time before merging https://github.com/nodejs/api-docs-tooling/blob/main/CONTRIBUTING.md#submitting-your-changes

This repository extends the Web Team contributing guidelines.

@AugustinMauroy
Copy link
Member

Oh 😥

@avivkeller avivkeller merged commit e44f080 into main Jun 24, 2025
10 checks passed
@avivkeller avivkeller deleted the feat/test-commands branch June 24, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants