Skip to content

fix(cli): align --skip-lint to skipLint #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025
Merged

fix(cli): align --skip-lint to skipLint #315

merged 1 commit into from
Jun 22, 2025

Conversation

avivkeller
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 22, 2025 16:30
@avivkeller avivkeller requested a review from a team as a code owner June 22, 2025 16:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Copy link

codecov bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.39%. Comparing base (18024ce) to head (05fb266).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
bin/commands/generate.mjs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   49.39%   49.39%           
=======================================
  Files          80       80           
  Lines        6818     6818           
  Branches      281      281           
=======================================
  Hits         3368     3368           
  Misses       3447     3447           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flakey5
Copy link
Member

flakey5 commented Jun 22, 2025

thanks!

@avivkeller avivkeller merged commit f26013f into main Jun 22, 2025
9 of 10 checks passed
@avivkeller avivkeller deleted the fix/skip-lint branch June 22, 2025 16:32
@avivkeller
Copy link
Member Author

Merged! (FtR Codecov's failure is more of a "hey, you should test this", rather than a hard block, see #305)

@ovflowd
Copy link
Member

ovflowd commented Jun 22, 2025

Don't forget to request fast tracking :)

@avivkeller
Copy link
Member Author

🤦

@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast track This PR can land before the typical review time, with a :+1: from collaborators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants