Conversation
Member
Author
|
Feel free to close this if the situation has changed or there otherwise is not consensus that this is the right thing to do. (I expect @RafaelGSS in particular to have a strong "yes" or "no" opinion on this.) Let's close #1081 once whatever decision we arrive at is made. |
Member
Author
|
@nodejs/tsc @nodejs/security-wg |
joyeecheung
approved these changes
Mar 8, 2023
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
It seems there are a fair bit of drive-by fixes above the deleted lines?
Member
Author
Yes. I can remove them and put them in a separate PR if that's preferable. |
Member
|
I think so. By their charter the security working group is responsible for keeping the node cves up-to-date. However, this is now done by the security steward. |
RafaelGSS
approved these changes
Mar 9, 2023
DanielRuf
approved these changes
Mar 9, 2023
UlisesGascon
approved these changes
Mar 12, 2023
It seems that the working group can function as a GitHub team. Closes: #1081
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the working group can function as a GitHub team.
Closes: #1081