meta: add security-wg ping to permission.js#47941
meta: add security-wg ping to permission.js#47941nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
daeyeon
added
the
author ready
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
RSLGTM. FWIW, do we think that the Ecosystem Security Working Group is the best group to review these changes?
Permission Model is one of the Security WG initiatives, so yes. Btw, there is no Ecosystem Security WG anymore. Just Security WG. |
debadree25
added
the
commit-queue
@RafaelGSS Sorry, I am a little confused. The README in https://github.com/nodejs/security-wg still says "Ecosystem Security WG". That WG seems to have been dechartered in nodejs/TSC#1351. Then there is nodejs/security-wg#874, which replaces "Ecosystem Security WG" with "Security WG," but my understanding is that it is just a regular GitHub team now and not actually a WG. Is that correct or am I missing something? |
|
Yes, it's supposed to be a team instead of a WG. That was one of @mhdawson requests in that PR nodejs/security-wg#874 (comment). Security WG seems easy to share at least. I'll include it in the agenda tomorrow. |
nodejs-github-bot
removed
the
commit-queue
|
Landed in 745083a |
PR-URL: #47941 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #47941 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #47941 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#47941 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
9 participants
No description provided.