Skip to content

[Snyk] Security upgrade urllib3 from 2.2.3 to 2.6.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nn6n wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 2.2.3 to 2.6.0 #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requires-optional.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,4 @@ shapely

## image uri conversion ##
pillow
urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@gemini-code-assist gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change introduces a dependency conflict that will likely break your CI build.

The new requirement urllib3>=2.6.0 is incompatible with requests==2.25.1, which is pinned in several test_requirements/*.txt files (e.g., test_requirements/requirements_310_optional.txt).

  • requests==2.25.1 requires urllib3<1.27.
  • This PR adds a requirement for urllib3>=2.6.0.

This conflict will cause pip to fail during dependency installation for test environments using the older requests version.

To resolve this, requests should be upgraded to a version compatible with urllib3>=2.0 (e.g., requests>=2.30.0) in all relevant test_requirements files. This PR should be updated to include those changes, or a new PR should be created to handle the requests upgrade.