-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade urllib3 from 2.2.3 to 2.6.0 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192442 - https://snyk.io/vuln/SNYK-PYTHON-URLLIB3-14192443
Summary of ChangesHello @nn6n, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical security vulnerabilities by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk aims to upgrade urllib3 to version 2.6.0 to address security vulnerabilities. While the intention is good, this change introduces a critical dependency conflict. The new urllib3 version is incompatible with older versions of requests that are pinned in several of this project's test requirement files. This will likely cause the CI builds to fail. Please see the detailed comment for more information.
|
|
||
| ## image uri conversion ## | ||
| pillow | ||
| urllib3>=2.6.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a dependency conflict that will likely break your CI build.
The new requirement urllib3>=2.6.0 is incompatible with requests==2.25.1, which is pinned in several test_requirements/*.txt files (e.g., test_requirements/requirements_310_optional.txt).
requests==2.25.1requiresurllib3<1.27.- This PR adds a requirement for
urllib3>=2.6.0.
This conflict will cause pip to fail during dependency installation for test environments using the older requests version.
To resolve this, requests should be upgraded to a version compatible with urllib3>=2.0 (e.g., requests>=2.30.0) in all relevant test_requirements files. This PR should be updated to include those changes, or a new PR should be created to handle the requests upgrade.
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
requires-optional.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling