Skip to content

[Snyk] Security upgrade urllib3 from 1.26.20 to 2.5.0 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 1.26.20 to 2.5.0 #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test_requirements/requirements_311_core.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
requests==2.25.1
pytest==7.4.4
narwhals>=1.15.1
narwhals>=1.15.1
urllib3>=2.5.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This direct pin of urllib3 to a 2.x version introduces a critical dependency conflict.

The requests package, pinned to 2.25.1 in this file, requires urllib3<1.27. The newly added urllib3>=2.5.0 requirement violates this constraint and will cause dependency resolution to fail.

To correctly resolve the urllib3 vulnerabilities, requests must be upgraded to a version that supports urllib3 v2.x. The first version of requests with this support is 2.31.0.

Recommended Action:

  1. Upgrade requests to at least version 2.31.0 in this file.
  2. Remove this added line pinning urllib3. The correct version will be pulled in as a transitive dependency of the updated requests package.
  3. Ensure the requests version is also updated in other relevant files, such as test_requirements/requirements_311_optional.txt, to maintain consistency.

After these changes, the top of this file should look like this:

requests>=2.31.0
pytest==7.4.4
narwhals>=1.15.1