[Snyk] Security upgrade urllib3 from 1.26.20 to 2.5.0

[nn6n]

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

• test_requirements/requirements_311_core.txt

⚠️ Warning

equests 2.25.1 requires urllib3, which is not installed.

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.
• Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Open Redirect

[gemini-code-assist]

Summary of Changes

Hello @nn6n, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to resolve two identified security vulnerabilities by upgrading the urllib3 dependency to a secure version and explicitly pinning it in the test requirements file.

Highlights

• Security Upgrade: This PR upgrades the urllib3 package from version 1.26.20 to 2.5.0 to address two identified security vulnerabilities (SNYK-PYTHON-URLLIB3-10390193 and SNYK-PYTHON-URLLIB3-10390194).
• Dependency Management: The urllib3 dependency is now explicitly pinned in test_requirements/requirements_311_core.txt. Previously, it was an indirect dependency of requests, but Snyk has added it directly to ensure the secure version is consistently used for testing.
• Automated Remediation: This pull request was automatically generated by Snyk as part of its automated vulnerability remediation process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, aims to upgrade urllib3 to fix security vulnerabilities. However, the proposed change introduces a critical dependency conflict. The new urllib3 version is incompatible with the currently used version of requests. My review includes a comment explaining the issue and providing a solution, which involves upgrading requests as well.

[gemini-code-assist]

This direct pin of urllib3 to a 2.x version introduces a critical dependency conflict.

The requests package, pinned to 2.25.1 in this file, requires urllib3<1.27. The newly added urllib3>=2.5.0 requirement violates this constraint and will cause dependency resolution to fail.

To correctly resolve the urllib3 vulnerabilities, requests must be upgraded to a version that supports urllib3 v2.x. The first version of requests with this support is 2.31.0.

Recommended Action:

1. Upgrade requests to at least version 2.31.0 in this file.
2. Remove this added line pinning urllib3. The correct version will be pulled in as a transitive dependency of the updated requests package.
3. Ensure the requests version is also updated in other relevant files, such as test_requirements/requirements_311_optional.txt, to maintain consistency.

After these changes, the top of this file should look like this:

requests>=2.31.0
pytest==7.4.4
narwhals>=1.15.1