Conversation
e-perl-NOAA
added
workflows
Rick-Methot-NOAA
approved these changes
Dec 19, 2023
Collaborator
Rick-Methot-NOAA
left a comment
Rick-Methot-NOAA
left a comment
There was a problem hiding this comment.
hope this works. Is it the reason my gha is failing?
Collaborator
Author
|
I think so, I don't know why the upload-artifacts action now doesn't want to upload artifacts in a folder under the same name anymore but this should allow all artifacts to upload now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
For some reason, the build-artifact workflow is no longer uploading all of the executables from the different operating systems to the same artifact named "ss3" (see artifact from PR #542). I have changed the workflow to upload an artifact for each OS, which is working (see workflow run here).
First seen in PR #541 by @iantaylor-NOAA.
What tests have been done?
Where are the relevant files?
What tests/review still need to be done?
None.
Is there an input change for users to Stock Synthesis?
Additional information (optional).