Skip to content

Comments

restore sizecomp bootstrap output#542

Merged
Rick-Methot-NOAA merged 6 commits intomainfrom
restore-boot-sizecomp
Dec 21, 2023
Merged

restore sizecomp bootstrap output#542
Rick-Methot-NOAA merged 6 commits intomainfrom
restore-boot-sizecomp

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

resolves issue #541

uses code that was created in issue #357 but accidentally deleted

Testing can use this zip, which may be a good candidate for adding to the test repo
D-M_test.zip

Testing demonstrates that data.expval and data.boot1 are different from data_echo.

iantaylor-NOAA
iantaylor-NOAA previously approved these changes Dec 19, 2023
Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone through the equations in detail but am trusting that they were correct before being accidentally left out of the pull request.

I don't see the build-ss3 in the automatic checks for this PR (perhaps because changes were underway), but I found it under the Actions tab and downloaded the ss3-windows-latest archive from there, which worked fine: https://github.com/nmfs-ost/ss3-source-code/actions/runs/7265855922.

Running that new executable with the simple_small_sizecomp model attached to #539 resulted in reasonable-looking bootstrap size comp samples in data_boot_001.ss, precise expected values in data_exp.ss, and accurate input data in data_echo.ss_new.

@Rick-Methot-NOAA Rick-Methot-NOAA dismissed iantaylor-NOAA’s stale review December 19, 2023 18:24

The merge-base changed after approval.

@e-perl-NOAA
Copy link
Collaborator

Build-ss3 workflow that I manually ran can be found here

@iantaylor-NOAA iantaylor-NOAA self-requested a review December 19, 2023 18:33
iantaylor-NOAA
iantaylor-NOAA previously approved these changes Dec 19, 2023
Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying again to review

@Rick-Methot-NOAA Rick-Methot-NOAA dismissed iantaylor-NOAA’s stale review December 19, 2023 18:34

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Size Frequency section in data_boot_001.ss and data_expval.ss identical to input file

3 participants