restore sizecomp bootstrap output#542
Conversation
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
I haven't gone through the equations in detail but am trusting that they were correct before being accidentally left out of the pull request.
I don't see the build-ss3 in the automatic checks for this PR (perhaps because changes were underway), but I found it under the Actions tab and downloaded the ss3-windows-latest archive from there, which worked fine: https://github.com/nmfs-ost/ss3-source-code/actions/runs/7265855922.
Running that new executable with the simple_small_sizecomp model attached to #539 resulted in reasonable-looking bootstrap size comp samples in data_boot_001.ss, precise expected values in data_exp.ss, and accurate input data in data_echo.ss_new.
The merge-base changed after approval.
|
Build-ss3 workflow that I manually ran can be found here |
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
trying again to review
The merge-base changed after approval.
resolves issue #541
uses code that was created in issue #357 but accidentally deleted
Testing can use this zip, which may be a good candidate for adding to the test repo
D-M_test.zip
Testing demonstrates that data.expval and data.boot1 are different from data_echo.