Skip to content

Comments

163 new style#372

Merged
Rick-Methot-NOAA merged 14 commits intomainfrom
163-new-style
Sep 27, 2022
Merged

163 new style#372
Rick-Methot-NOAA merged 14 commits intomainfrom
163-new-style

Conversation

@nschindler-noaa
Copy link
Contributor

Concisely (20 words or less) describe the issue

Finalize coding style guide and .clang-format to match.

Please Link issue(s)

resolves #293, resolves #311

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

Has any new code been documented?

If not, please add documentation before submitting the Pull Request.

  • I have documented any new code added (or no new code was added)

is there an input change for users to Stock Synthesis?

  • Yes, there was an input change

If so, please provide an example of the new inputs needed.

[New example stock synthesis input goes here]

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):

If changes are needed in the change log, please fill in the table here:

Action Topics Type
[fix, new, or revise] [e.g., biology. Use issue label options.] [input, output, and/or calc, or ALL]

Additional information (optional):

Copy link
Collaborator

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Neal for wrapping this up.

@Rick-Methot-NOAA Rick-Methot-NOAA merged commit 2bb1028 into main Sep 27, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA deleted the 163-new-style branch February 7, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Choose a style guide for SS3 code Missing curly braces with for loops?

2 participants