Missing curly braces with for loops?

[k-doering-NOAA]

I noticed in some cases curly braces are omitted, e.g.,
https://github.com/nmfs-stock-synthesis/stock-synthesis/blob/020d4f07470195843ad53aa6cac810da43102645/SS_objfunc.tpl#L135-L141

I think for more readable code, it would be great to add them. I started to do this in the MV-tweedie-complike branch locally and then realized I should ask.

@Rick-Methot-NOAA, Is there any reason this change shouldn't be made?

And if I do make it, should it be done in a separate feature branch or is MV-tweedie-complike ok?

[Rick-Methot-NOAA]

I was hoping the styler would have added the {} wherever they we missing. So add at our convenience

[k-doering-NOAA]

Yes, I was hoping that, too.

Maybe this is a question for @nschindler-noaa : are there any options that will add in missing curly braces?

[nschindler-noaa]

There is a clang-format option that will do this, and it may work with a different version of clang-format than I have; but I was not able to make it work and it failed the reformat.

On Mon, Apr 18, 2022 at 2:53 PM Kathryn Doering ***@***.***> wrote: Yes, I was hoping that, too. Maybe this is a question for @nschindler-noaa <https://github.com/nschindler-noaa> : are there any options that will add in missing curly braces? — Reply to this email directly, view it on GitHub <#293 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARUZACR3FJCIBDSHVP5AH53VFXKT7ANCNFSM5TW6BC2Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Neal Schindler Programmer Analyst, Caelum NWFSC (206) 860-3407 cell (206) 909-0505

=(((`< >=(((`< >=(((`<

=(((`<

[nschindler-noaa]

BTW, this tool (or tools) is designed to work on a single file, so you don't have to reformat the entire code base after making some changes in a single file. Another option would be to create a .bat file that will format only the files that successfully reformat. On Tue, Apr 19, 2022 at 10:59 AM Neal Schindler - NOAA Affiliate < ***@***.***> wrote:

There is a clang-format option that will do this, and it may work with a different version of clang-format than I have; but I was not able to make it work and it failed the reformat. On Mon, Apr 18, 2022 at 2:53 PM Kathryn Doering ***@***.***> wrote: > Yes, I was hoping that, too. > > Maybe this is a question for @nschindler-noaa > <https://github.com/nschindler-noaa> : are there any options that will > add in missing curly braces? > > — > Reply to this email directly, view it on GitHub > <#293 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ARUZACR3FJCIBDSHVP5AH53VFXKT7ANCNFSM5TW6BC2Q> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- Neal Schindler Programmer Analyst, Caelum NWFSC (206) 860-3407 cell (206) 909-0505 >=(((`< >=(((`< >=(((`< >=(((`<

-- Neal Schindler Programmer Analyst, Caelum NWFSC (206) 860-3407 cell (206) 909-0505

=(((`< >=(((`< >=(((`<

=(((`<

[k-doering-NOAA]

I see, that's a bummer it didn't work.

I like that the tools run on a single file; it's always easy to write code (batch file, r script) to process multiple!

[Rick-Methot-NOAA]

Is the issue with routinely running the tools that running the first tool makes some unwanted changes that are undone by the second?
I have noticed that blank lines are getting two spaces, so are not completely blank.

[nschindler-noaa]

Yes, exactly. If they need to be completely blank, that is (I think) an easy change.

[Rick-Methot-NOAA]

They do not need to be blank, but while making files clean, let's do all we can

[nschindler-noaa]

Ok, sounds good. I'll update tpl_format

On Tue, Apr 19, 2022 at 2:05 PM Richard Methot ***@***.***> wrote: They do not need to be blank, but while making files clean, let's do all we can — Reply to this email directly, view it on GitHub <#293 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARUZACS44FSIXAK7R4YURK3VF4N2VANCNFSM5TW6BC2Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Neal Schindler Programmer Analyst, Caelum NWFSC (206) 860-3407 cell (206) 909-0505

=(((`< >=(((`< >=(((`<

=(((`<