fix extra value in M table (2nd try)#368
Merged
Rick-Methot-NOAA merged 1 commit intomainfrom Aug 19, 2022
Merged
Conversation
- section revised in #307 - 2nd try after previous building edit onto wrong branch
Contributor
Author
|
Failed |
Rick-Methot-NOAA
approved these changes
Aug 19, 2022
Collaborator
Rick-Methot-NOAA
left a comment
There was a problem hiding this comment.
good catch. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely (20 words or less) describe the issue
The recently-revised (in #307) Natural_Mortality table in Report.sso has an extra value in the output
This PR replaces #367 which accidentally was based on the
MV-Tweedie-ver2branch instead ofmain.Please Link issue(s)
No issue. Just a quick fix to a minor bug (example below).
What tests have been done? Upload any model input files created for testing in a zip file, if possible.
Compiled SS3, ran a single model, confirm that the table looks correct.
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
Usual automated tests via GitHub action.
Has any new code been documented?
If not, please add documentation before submitting the Pull Request.
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):
Additional information (optional):
Example of the output with the extra "TIME" value in the "BENCH" rows: