Skip to content

Comments

M table fix#367

Closed
iantaylor-NOAA wants to merge 17 commits intomainfrom
M_table_fix
Closed

M table fix#367
iantaylor-NOAA wants to merge 17 commits intomainfrom
M_table_fix

Conversation

@iantaylor-NOAA
Copy link
Contributor

Concisely (20 words or less) describe the issue

The recently-revised (in #307) Natural_Mortality table in Report.sso has an extra value in the output

Please Link issue(s)

No issue. Just a quick fix to a minor bug (example below).

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

Compiled SS3, ran a single model, confirm that the table looks correct.

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

Usual automated tests via GitHub action.

Has any new code been documented?

If not, please add documentation before submitting the Pull Request.

  • I have documented any new code added (or no new code was added)

Check which is true. This PR requires:

  • no further changes to r4ss
  • no further changes to the manual
  • no further changes to SSI (the SS3 GUI)
  • no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI that are needed (if not checked):

Additional information (optional):

Example of the output with the extra "TIME" value in the "BENCH" rows:

Natural_Mortality report:43
Method: 0
Area Bio_Pattern Sex BirthSeas Settlement Platoon Morph Yr Seas Time Beg/Mid Era 0 1 2 ...
1 1 1 1 1 1 1 1968 1 1968 B BENCH  TIME  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1968 2 1968.96 B BENCH  TIME  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1969 1 1969 B VIRG  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1969 2 1969.96 B VIRG  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1970 1 1970 B INIT  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1970 2 1970.96 B INIT  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1971 1 1971 B TIME  0.1 0.1 0.1 ...
1 1 1 1 1 1 1 1971 2 1971.96 B TIME  0.1 0.1 0.1 ...

@iantaylor-NOAA iantaylor-NOAA added bug Something isn't working; don't remove label after fixing misc. output labels Aug 19, 2022
@iantaylor-NOAA iantaylor-NOAA added this to the 3.30.20 milestone Aug 19, 2022
@iantaylor-NOAA
Copy link
Contributor Author

Oops, failed to update main branch before creating this PR, will try again.

@iantaylor-NOAA iantaylor-NOAA deleted the M_table_fix branch September 9, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working; don't remove label after fixing misc. output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants