Skip to content

Comments

add reporting for virg and inityr for predators#334

Merged
Rick-Methot-NOAA merged 1 commit intomainfrom
clean_up_M2_output
Jun 19, 2022
Merged

add reporting for virg and inityr for predators#334
Rick-Methot-NOAA merged 1 commit intomainfrom
clean_up_M2_output

Conversation

@Rick-Methot-NOAA
Copy link
Collaborator

What issue(s) does this PR address? Describe and add issue numbers, if applicable.

Link issue(s) here:
none

What tests have been done? Upload any model input files created for testing in a zip file, if possible.

visual exam using vendance model

What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?

the gha will be sufficient

Check which is true. This PR requires:

  • [ x] no further changes to r4ss
  • [ x] no further changes to the manual
  • [x ] no further changes to SSI (the SS3 GUI)
  • [x ] no further changes to the stock synthesis change log (new features, bug reports)

Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):

none

Additional information (optional):

This change fills in blanks for pred_M2 and associated catch for the virgin and initial equilibrium years

@Rick-Methot-NOAA Rick-Methot-NOAA added misc. output predator related to M2, predation mortality labels Jun 18, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA added this to the 3.30.20 milestone Jun 18, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA self-assigned this Jun 18, 2022
@Rick-Methot-NOAA Rick-Methot-NOAA removed the request for review from k-doering-NOAA June 19, 2022 18:47
@Rick-Methot-NOAA Rick-Methot-NOAA merged commit c578c7d into main Jun 19, 2022
@Rick-Methot-NOAA
Copy link
Collaborator Author

While working on this issue, I discovered that the predator approach in 3.30.18.00 was flawed and did not handle time-varying pred_M2 correctly. This problem with 3.30.18 was fixed by #307 and #310, with the final clean-up happening here.

@Rick-Methot-NOAA Rick-Methot-NOAA deleted the clean_up_M2_output branch June 21, 2022 17:49
@Rick-Methot-NOAA Rick-Methot-NOAA added the change log use for issues that should appear in change log label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change log use for issues that should appear in change log misc. output predator related to M2, predation mortality

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant