Merged
Conversation
k-doering-NOAA
added
the
bug
Contributor
|
@Rick-Methot-NOAA , thanks for this quick fix! Will this change be needed when we merge in #307 ? If not, I'm curious why it is being made? |
Collaborator
Author
|
The change will not be needed after we merge in #307, but a one line fix to the main branch while waiting for a hundreds of lines development branch seemed like a good idea. |
k-doering-NOAA
approved these changes
May 11, 2022
Contributor
k-doering-NOAA
left a comment
k-doering-NOAA
left a comment
There was a problem hiding this comment.
Thanks, Rick. That makes sense.
Collaborator
Author
|
I do not think we need to release this as a formal fix as it affects only the predation applications. But it is good to have in case it is needed. |
Rick-Methot-NOAA
added
the
change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue(s) does this PR address? Describe and add issue numbers, if applicable.
Link issue(s) here:
fix to main to repair M in forecast when predators are used. Note that a separate development branch changes the pred_M2 approach and is not affected by this problem
What tests have been done? Upload any model input files created for testing in a zip file, if possible.
detailed test using vendance
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
none
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):
this must get noted in the change log
Additional information (optional):