convert natM(s to natM(t as first step in transitional SPR#302
Closed
Rick-Methot-NOAA wants to merge 2 commits intomainfrom
Closed
convert natM(s to natM(t as first step in transitional SPR#302Rick-Methot-NOAA wants to merge 2 commits intomainfrom
Rick-Methot-NOAA wants to merge 2 commits intomainfrom
Conversation
Collaborator
Author
|
@k-doering-NOAA please check to see that I did not disable your recent fix for fspr nan. |
Contributor
|
@Rick-Methot-NOAA I checked, and you did not disable the spr nan fixes. SO all good! Let me know when you push your last commit, I can take a look at the code (or Neal could?) before it gets merged in! |
This was
linked to
issues
May 5, 2022
Contributor
|
Closing, because commits included in #307 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue(s) does this PR address? Describe and add issue numbers, if applicable.
#88 this conversion of natM indexing is first needed step
What tests have been done? Upload any model input files created for testing in a zip file, if possible.
runs with simple and hake_2018
What tests/review still need to be done? Who can do it, and by when is it needed (ideally)?
Check which is true. This PR requires:
Describe any changes in r4ss/SS3 manual/SSI/change log that are needed (if not checked):
Additional information (optional):