Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a ci step for Json_Diagnostic_Positions #4579

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

hnampally
Copy link
Contributor

@hnampally hnampally commented Jan 1, 2025

This PR brings the change to add a CI step for the new feature Json_Diagnostic_Positions


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

@coveralls
Copy link

coveralls commented Jan 1, 2025

Coverage Status

coverage: 99.639%. remained the same
when pulling c1e8021 on hnampally:develop
into 4f64d8d on nlohmann:develop.

cmake/ci.cmake Outdated Show resolved Hide resolved
cmake/ci.cmake Outdated Show resolved Hide resolved
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign-off your commit(s).

cmake/ci.cmake Outdated Show resolved Hide resolved
@hnampally
Copy link
Contributor Author

Please sign-off your commit(s).

I made the changes and and pushed this commit 2d04d40 from the browser, so I think it was not properly signed off, sorry about that.

@nlohmann
Copy link
Owner

nlohmann commented Jan 1, 2025

Please sign-off your commit(s).

I made the changes and and pushed this commit 2d04d40 from the browser, so I think it was not properly signed off, sorry about that.

Do you have access to https://github.com/nlohmann/json/pull/4579/checks?check_run_id=35047024834? This contains an explanation how to fix this.

@hnampally
Copy link
Contributor Author

hnampally commented Jan 1, 2025

Please sign-off your commit(s).

I made the changes and and pushed this commit 2d04d40 from the browser, so I think it was not properly signed off, sorry about that.

Do you have access to https://github.com/nlohmann/json/pull/4579/checks?check_run_id=35047024834? This contains an explanation how to fix this.

Yes, thanks for the pointer, I will fix and push it shortly.

Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
cmake/ci.cmake Outdated Show resolved Hide resolved
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
cmake/ci.cmake Outdated Show resolved Hide resolved
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
cmake/ci.cmake Outdated Show resolved Hide resolved
cmake/ci.cmake Show resolved Hide resolved
Signed-off-by: Harinath Nampally <harinath922@gmail.com>
@github-actions github-actions bot added the CI label Jan 3, 2025
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 3, 2025
@nlohmann nlohmann merged commit a6255cc into nlohmann:develop Jan 3, 2025
125 checks passed
@nlohmann
Copy link
Owner

nlohmann commented Jan 3, 2025

Thanks!

slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
* add a ci step for Json_Diagnostic_Positions

Signed-off-by: Harinath Nampally <harinath922@gmail.com>

* Update ci.cmake to address review comments

Signed-off-by: Harinath Nampally <harinath922@gmail.com>

* address review comment

Signed-off-by: Harinath Nampally <harinath922@gmail.com>

* fix typo in the comment

Signed-off-by: Harinath Nampally <harinath922@gmail.com>

* fix typos in ci.cmake

Signed-off-by: Harinath Nampally <harinath922@gmail.com>

* invoke the new ci step from ubuntu.yml

Signed-off-by: Harinath Nampally <harinath922@gmail.com>

---------

Signed-off-by: Harinath Nampally <harinath922@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants