Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the abi tests for diagnostics positions feature #4572

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

hnampally
Copy link
Contributor

This PR changes fix the issue #4571, when 'JSON_Diagnostic_Positions' cmake option is enabled, we need to cover JSON_DIAGNOSTIC_POSITIONS preprocessor directive as well.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

@coveralls
Copy link

Coverage Status

coverage: 99.639%. remained the same
when pulling cec0474 on harytary:issue4571-abi-tests-fix
into 6be4e85 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann
Copy link
Owner

Thanks! We really need to add a CI step for this...

@nlohmann nlohmann added this to the Release 3.11.4 milestone Dec 28, 2024
@hnampally
Copy link
Contributor Author

Yes, I will raise a PR for a CI step as well.

@nlohmann
Copy link
Owner

Yes, I will raise a PR for a CI step as well.

That would be the place to add the change: https://github.com/nlohmann/json/blob/develop/cmake/ci.cmake#L894_L955

Target ci_cmake_flags is executed by the CI in the Ubuntu workflow, but right now, we only call CMake with the respective flags, but do not build and run the tests.

@nlohmann nlohmann merged commit 69c8758 into nlohmann:develop Dec 28, 2024
123 checks passed
@nlohmann nlohmann linked an issue Dec 28, 2024 that may be closed by this pull request
2 tasks
@hnampally
Copy link
Contributor Author

Yes, I will raise a PR for a CI step as well.

That would be the place to add the change: https://github.com/nlohmann/json/blob/develop/cmake/ci.cmake#L894_L955

Target ci_cmake_flags is executed by the CI in the Ubuntu workflow, but right now, we only call CMake with the respective flags, but do not build and run the tests.

Okay sounds good, thanks for the link.

@nlohmann
Copy link
Owner

nlohmann commented Jan 3, 2025

Thanks! We really need to add a CI step for this...

Added with #4579.

slowriot pushed a commit to slowriot/json that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couple of ABI tests failed upon enabling JSON_Diagnostic_Positions cmake option
3 participants