Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Skopeo patch hash #150

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Update the Skopeo patch hash #150

merged 1 commit into from
Aug 30, 2024

Conversation

nlewo
Copy link
Owner

@nlewo nlewo commented Aug 29, 2024

It looks like GitHub changed the way their are generating patches. Here are differences:

diff c2254c998433cf02af60bf0292042bd80b96a77e.patch /nix/store/xk6z74qc073dvs1ngvk58qqby73q6yx9-c2254c998433cf02af60bf0292042bd80b96a77e.patch
18c18
< index 0000000000..46e737dc78
---
> index 000000000..46e737dc7
229c229
< index 0bae8b2599..34cf925c29 100644
---
> index 0bae8b259..34cf925c2 100644

@nlewo
Update the Skopeo patch hash
80e3477 
It looks like GitHub changed the way their are generating
patches. Here are differences:

    diff c2254c998433cf02af60bf0292042bd80b96a77e.patch /nix/store/xk6z74qc073dvs1ngvk58qqby73q6yx9-c2254c998433cf02af60bf0292042bd80b96a77e.patch
    18c18
    < index 0000000000..46e737dc78
    ---
    > index 000000000..46e737dc7
    229c229
    < index 0bae8b2599..34cf925c29 100644
    ---
    > index 0bae8b259..34cf925c2 100644
@nlewo nlewo mentioned this pull request Aug 29, 2024
Closed
@nlewo
Copy link
Owner Author

nlewo commented Aug 29, 2024

This is actually because of the number of objects in the repository: NixOS/nixpkgs#257446

@chasecaleb
Copy link

Not sure if you're waiting for feedback before merging this, but switching to this branch resolved the issue for me 👍

@aaronmondal aaronmondal mentioned this pull request Aug 29, 2024
Merged
8 tasks
@nlewo
Copy link
Owner Author

nlewo commented Aug 30, 2024

CI locally passed.

@chasecaleb thx for your feedback.

@nlewo nlewo merged commit fa6bb0a into master Aug 30, 2024
2 of 3 checks passed
@the-sun-will-rise-tomorrow
Copy link

I think you want to add ?full_index=1 to the URL, as mentioned in the linked issue. As it is, this PR is a temporary fix.

@the-sun-will-rise-tomorrow
Copy link

Or, even better, use fetchpatch, which takes care of this problem automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlewo @chasecaleb @the-sun-will-rise-tomorrow