Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken variables in NativeLink Cloud CI jobs and disable RBE test #1293

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

bclark8923
Copy link
Member

@bclark8923 bclark8923 commented Aug 29, 2024

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@bclark8923 bclark8923 changed the title Fix broken variables in NativeLink Cloud CI jobs Update RBE Documentation Aug 29, 2024
Copy link
Member

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, and 1 discussions need to be resolved


.github/workflows/main.yml line 63 at r1 (raw file):

          --remote_header=x-nativelink-project=nativelink-ci \
          --remote_executor=grpcs://scheduler-tracemachina-shared.build-faster.nativelink.net:443 \
          --remote_default_exec_properties="container-image=docker://$RBE_IMAGE" \

This is the most annoying github thing.. almost looks like a shell variable but isn't. ${RBE_IMAGE} doesn't work on github actions

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

fyi we need to fix the hash mismatch outlined in nlewo/nix2container#150 to unblock this.

Reviewed all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and pending CI: Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, and 1 discussions need to be resolved

@bclark8923 bclark8923 marked this pull request as draft August 29, 2024 21:53
@aaronmondal
Copy link
Member

Sent #1294 to fix the OCI workflow

@bclark8923 bclark8923 changed the title Update RBE Documentation Fix broken variables in NativeLink Cloud CI jobs and disable RBE test Aug 29, 2024
@bclark8923 bclark8923 marked this pull request as ready for review August 29, 2024 23:00
@bclark8923 bclark8923 enabled auto-merge (squash) August 29, 2024 23:00
Copy link
Member Author

@bclark8923 bclark8923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained, and all files reviewed

@bclark8923 bclark8923 merged commit f4ae4cc into TraceMachina:main Aug 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants