Skip to content

Use homeModules as flake output name for Home Manager modules (backport #3387) #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 25, 2025

This PR contains a handful of changes centered around the flake output for Home Manager modules. My understanding is that, recently, convention has been converging on using homeModules as the name of the flake output (as this is closer to homeConfigurations and more in line with nixosModules/nixosConfigurations), which is the focus of this PR.

This PR contains a few commits. The first simply adds homeModules as an alias of homeManagerModules. The second migrates documentation and internal uses of homeManagerModules to use homeModules instead, and the third inverts the first by defining homeManagerModules in terms of homeModules, treating it as a backward-compatibility layer. I'm not sure what the stance of the project is on this issue, but while I'd personally like to see all three land, just having homeModules available as an option (i.e., just the first commit here) would satisfy me.


This is an automatic backport of pull request #3387 done by Mergify.

@MattSturgeon

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor Author

mergify bot commented May 25, 2025

This pull request, with head sha cfea16cdbe4f13b5d39dfe3df747092448252c9d, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha cfea16cdbe4f13b5d39dfe3df747092448252c9d is part of the nixos-25.05 branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch mergify/bp/nixos-25.05/pr-3387, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit cfea16c into nixos-25.05 May 25, 2025
4 checks passed
@MattSturgeon MattSturgeon deleted the mergify/bp/nixos-25.05/pr-3387 branch May 25, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants