Skip to content

Use homeModules as flake output name for Home Manager modules #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2025

Conversation

Aehmlo
Copy link
Contributor

@Aehmlo Aehmlo commented May 25, 2025

This PR contains a handful of changes centered around the flake output for Home Manager modules. My understanding is that, recently, convention has been converging on using homeModules as the name of the flake output (as this is closer to homeConfigurations and more in line with nixosModules/nixosConfigurations), which is the focus of this PR.

This PR contains a few commits. The first simply adds homeModules as an alias of homeManagerModules. The second migrates documentation and internal uses of homeManagerModules to use homeModules instead, and the third inverts the first by defining homeManagerModules in terms of homeModules, treating it as a backward-compatibility layer. I'm not sure what the stance of the project is on this issue, but while I'd personally like to see all three land, just having homeModules available as an option (i.e., just the first commit here) would satisfy me.

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

I didn't realize we were still using homeManagerModules even after I personally pushed to standardize on using homeModules upstream 😅

Diff LGTM, but it'd be nice to add a warning as part of this PR if you're able.

@Aehmlo
Copy link
Contributor Author

Aehmlo commented May 25, 2025

Thanks for picking this up!

Happy to help! Glad the project seems amenable to this change.

I didn't realize we were still using homeManagerModules even after I personally pushed to standardize on using homeModules upstream 😅

Thank you for helping make this standardization process happen! :)

Diff LGTM, but it'd be nice to add a warning as part of this PR if you're able.

Done in a follow-up commit. I refrained from squashing/rebasing, since I know GitHub doesn't play nicely with that, but happy to clean up the history a little bit if desired before merging.

@MattSturgeon

This comment was marked as resolved.

Copy link
Contributor

mergify bot commented May 25, 2025

backport nixos-25.05

✅ Backports have been created

@MattSturgeon

This comment was marked as resolved.

Copy link
Contributor

mergify bot commented May 25, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b37d429

Copy link
Contributor

mergify bot commented May 25, 2025

This pull request, with head sha b37d429468c1f5133743e967caf97d92dc35ef5b, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha b37d429468c1f5133743e967caf97d92dc35ef5b is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch home-modules, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit b37d429 into nix-community:main May 25, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages May 25, 2025 18:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants