-
-
Notifications
You must be signed in to change notification settings - Fork 333
Use homeModules as flake output name for Home Manager modules #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
I didn't realize we were still using homeManagerModules
even after I personally pushed to standardize on using homeModules
upstream 😅
Diff LGTM, but it'd be nice to add a warning as part of this PR if you're able.
Happy to help! Glad the project seems amenable to this change.
Thank you for helping make this standardization process happen! :)
Done in a follow-up commit. I refrained from squashing/rebasing, since I know GitHub doesn't play nicely with that, but happy to clean up the history a little bit if desired before merging. |
This comment was marked as resolved.
This comment was marked as resolved.
✅ Backports have been created
|
This comment was marked as resolved.
This comment was marked as resolved.
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b37d429 |
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
This PR contains a handful of changes centered around the flake output for Home Manager modules. My understanding is that, recently, convention has been converging on using
homeModules
as the name of the flake output (as this is closer tohomeConfigurations
and more in line withnixosModules
/nixosConfigurations
), which is the focus of this PR.This PR contains a few commits. The first simply adds
homeModules
as an alias ofhomeManagerModules
. The second migrates documentation and internal uses ofhomeManagerModules
to usehomeModules
instead, and the third inverts the first by defininghomeManagerModules
in terms ofhomeModules
, treating it as a backward-compatibility layer. I'm not sure what the stance of the project is on this issue, but while I'd personally like to see all three land, just havinghomeModules
available as an option (i.e., just the first commit here) would satisfy me.