Skip to content

Add the dracula.nvim plugin #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add the dracula.nvim plugin #2149

wants to merge 2 commits into from

Conversation

refaelsh
Copy link
Contributor

@refaelsh refaelsh commented Sep 2, 2024

This PR adds the dracula.nvim plugin.
Here the link to nixpkgs: https://search.nixos.org/packages?channel=24.05&show=vimPlugins.dracula-nvim&from=0&size=50&sort=relevance&type=packages&query=dracula-nvim.

Thanks in advance for reviewing :-)

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is caused by #2140

Otherwise everything looks good.

If you could rebase so we no longer have the "merge" commit, that'd be great. Otherwise we'll tackle squashing/rebasing.

pkgs,
...
}:
lib.nixvim.neovim-plugin.mkNeovimPlugin config {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recently changed,

Suggested change
lib.nixvim.neovim-plugin.mkNeovimPlugin config {
lib.nixvim.neovim-plugin.mkNeovimPlugin {

lib.nixvim.neovim-plugin.mkNeovimPlugin config {
name = "dracula";
originalName = "dracula.nvim ";
defaultPackage = pkgs.vimPlugins.dracula-nvim;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently correct, but may change if #2139 is merged first.

@@ -0,0 +1,20 @@
{
lib,
config,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config,

@refaelsh refaelsh closed this Sep 3, 2024
@refaelsh refaelsh deleted the add-dracula-nvim branch September 3, 2024 18:22
@refaelsh
Copy link
Contributor Author

refaelsh commented Sep 3, 2024

I did something bad. Not really sure. Probably the "rebasing" failed. Sorry for the inconvinience. I will open a new PR.

@MattSturgeon
Copy link
Member

@refaelsh did you close this intentionally? I didn't think there was much work needed to get it finished and merged 😨

@refaelsh
Copy link
Contributor Author

refaelsh commented Sep 3, 2024

@refaelsh did you close this intentionally? I didn't think there was much work needed to get it finished and merged 😨

I did something bad. Not really sure. Probably the "rebasing" failed. Sorry for the inconvinience. I will open a new PR.

@MattSturgeon
Copy link
Member

MattSturgeon commented Sep 3, 2024

Ah, perhaps you did something like git push --delete origin add-dracula-nvim or git push origin :add-dracula-nvim (equivalent).

I think github usually has a "restore branch" button on PRs, once restored it should be possible to re-open. Otherwise, a new PR is fine 🙂

@refaelsh
Copy link
Contributor Author

refaelsh commented Sep 3, 2024

Here is the new PR: #2153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants