Skip to content

lib/*-plugin: drop config arg #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2024
Merged

lib/*-plugin: drop config arg #2140

merged 2 commits into from
Sep 2, 2024

Conversation

MattSturgeon
Copy link
Member

@MattSturgeon MattSturgeon commented Sep 1, 2024 •
edited
Loading

  • lib/vim-plugin: drop config arg
  • lib/neovim-plugin: drop config arg

Instead of passing in config explicitly, we can access it via an imported module.

This will work better if we need to access additional module args, such as options or pkgs.

traxys
traxys approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@traxys traxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not check that none was forgotten, but that should be handled by tests

khaneliman
khaneliman approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traxys traxys mentioned this pull request Sep 1, 2024
Merged
@MattSturgeon
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 18b7597

@mergify mergify bot merged commit 18b7597 into nix-community:main Sep 2, 2024
4 checks passed
@MattSturgeon MattSturgeon deleted the mkplugin-import branch September 2, 2024 09:58
@MattSturgeon MattSturgeon mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaneliman khaneliman khaneliman approved these changes

@traxys traxys traxys approved these changes

@GaetanLepage GaetanLepage Awaiting requested review from GaetanLepage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattSturgeon @khaneliman @traxys