Skip to content

ENH: Subclass RobustTemplate from FSCommandOpenMP #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2017

Conversation

effigies
Copy link
Member

Changes proposed in this pull request

  • Subclassing from FSCommandOpenMP enables the num_threads input

954f3b3 is the commit that matters. The style commit should have no semantic changes.

Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effigies effigies merged commit 3b15d39 into nipy:master Jul 28, 2017
@effigies effigies deleted the enh/robust_openmp branch July 28, 2017 18:16
@oesteban
Copy link
Contributor

The build failed:

Traceback (most recent call last):

  File "/src/nipype/tools/run_examples.py", line 64, in <module>

    run_examples(example, pipelines, data_path, plugin)

  File "/src/nipype/tools/run_examples.py", line 48, in run_examples

    wf.run(plugin=plugin, plugin_args=plugin_args)

  File "/src/nipype/nipype/pipeline/engine/workflows.py", line 596, in run

    write_workflow_prov(execgraph, prov_base, format='all')

  File "/src/nipype/nipype/pipeline/engine/utils.py", line 1291, in write_workflow_prov

    ps.write_provenance(filename, format=format)

  File "/src/nipype/nipype/utils/provenance.py", line 436, in write_provenance

    self.g.serialize(filename + ext, format='rdf', rdf_format=rdf_format)

  File "/usr/local/miniconda/lib/python2.7/site-packages/prov/model.py", line 2402, in serialize

    serializer.serialize(stream, **args)

  File "/usr/local/miniconda/lib/python2.7/site-packages/prov/serializers/provrdf.py", line 97, in serialize

    container.serialize(buf, **newargs)

  File "/usr/local/miniconda/lib/python2.7/site-packages/rdflib/graph.py", line 943, in serialize

    serializer.serialize(stream, base=base, encoding=encoding, **args)

  File "/usr/local/miniconda/lib/python2.7/site-packages/rdflib/plugins/serializers/trig.py", line 57, in serialize

    self.preprocess()

  File "/usr/local/miniconda/lib/python2.7/site-packages/rdflib/plugins/serializers/trig.py", line 35, in preprocess

    self.getQName(context.identifier)

  File "/usr/local/miniconda/lib/python2.7/site-packages/rdflib/plugins/serializers/turtle.py", line 274, in getQName

    prefix = self.addNamespace(prefix, namespace)

  File "/usr/local/miniconda/lib/python2.7/site-packages/rdflib/plugins/serializers/turtle.py", line 202, in addNamespace

    super(TurtleSerializer, self).addNamespace(prefix, namespace)

  File "/usr/local/miniconda/lib/python2.7/site-packages/rdflib/plugins/serializers/turtle.py", line 51, in addNamespace

    raise Exception("Trying to override namespace prefix %s => %s, but it's already bound to %s"%(prefix, uri, self.namespaces[prefix]))

Exception: Trying to override namespace prefix pns1 => http://iri.nidash.org/37, but it's already bound to http://iri.nidash.org/3683467

But I think this is unrelated

@effigies
Copy link
Member Author

Yeah. Every build is failing with that right now.

effigies added a commit to nipreps/niworkflows that referenced this pull request Jul 28, 2017
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants