-
Notifications
You must be signed in to change notification settings - Fork 532
WIP - BF - give sdc_fmb access to ants reg settings (esp initial_moving_transform_com) #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1952 +/- ##
===========================================
- Coverage 72.51% 45.57% -26.94%
===========================================
Files 1063 1063
Lines 54209 54196 -13
Branches 7825 7826 +1
===========================================
- Hits 39307 24701 -14606
- Misses 13680 29446 +15766
+ Partials 1222 49 -1173
Continue to review full report at Codecov.
|
'winsorize_upper_quantile': 0.995, | ||
} | ||
defaults.update(alternatives) | ||
for k,v in defaults.iteritems(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe this for loop can be replaced with: fmb20.inputs.trait_set(**defaults)
@WillForan, a couple of suggestions here:
|
@satra: WDYT about shipping some settings for ANTS?, so that users can start off reliable options and experts from the ITK/ANTs world can vet them. |
@oesteban - i think any settings that are helpful would be nice. although ants folks thinks of ants as a framework and one may need to optimize settings for each use case. so i don't know whether we should include them or simply create a set of json files that people could use for various ants needs. |
@satra I think settings like the ones you showed me once for T1w to MNI registration (which are pretty close -if not the same- to those they use in the Then, some other settings like this registration here, you are to release the workflow with a certain set of parameters anyway, so why don't you give them a better place and make them available to other workflows and interfaces? |
Running
sdc_fmb
wherein_file
andbmap_mag
orphase
are not close in coordinate space results in error running antsSetting
initial_moving_transform_com = 1
resolves this error.This pull request creates a new function
antreg_fmm2b0
where ant settings can be changed or added.sdc_fmb
is parameterized to to use the new function.