Skip to content

[ENH] Sorting out Dockerfiles #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 16, 2017
Merged

Conversation

oesteban
Copy link
Contributor

@oesteban oesteban commented Feb 14, 2017

Software to be included in this image for tests:

  • FSL
  • FreeSurfer
  • SPM
  • ANTs
  • AFNI
  • dcm2niix
  • nipy
  • C3D_affine_tool
  • VTK

Environments:

  • python 2.7
  • python 3.4
  • python 3.5

@satra
Copy link
Member

satra commented Feb 15, 2017

@oesteban - for freesurfer are we including the entire image or breaking out pieces?

@oesteban
Copy link
Contributor Author

@satra entire image

@oesteban
Copy link
Contributor Author

Can we leave dcm2niix and VTK for another PR?

As regards FreeSurfer, is there any place where I can find a lightweight version? (BTW, this upgrades FreeSurfer to v. 6.0.0).

@oesteban oesteban changed the title [WIP] Sorting out Dockerfiles [ENH] Sorting out Dockerfiles Feb 15, 2017
@oesteban
Copy link
Contributor Author

Question:

We have these two docker build commands in the circle.yml:

    - docker build -f docker/Dockerfile_py27 -t nipype/nipype_test:py27 . :
        timeout: 1600
    - docker build -f docker/Dockerfile_py35 -t nipype/nipype_test:py35 . :
        timeout: 1600

They take ~3 and ~1 min respectively but they are not cached. Do we want to cache them?

@satra
Copy link
Member

satra commented Feb 15, 2017

does circle rebuild cache if docker/Dockerfile_py[27|35] changes? if so sure.

@oesteban
Copy link
Contributor Author

Yeah, it rebuilds, I'll add caching for them.

@oesteban
Copy link
Contributor Author

@satra what did you have in mind about freesurfer?

@satra
Copy link
Member

satra commented Feb 16, 2017

@oesteban - freesurfer has many components and expands out to over 8G. if we just want it for recon-all, we can strip it down to about 500MB. if we want tracula, and cvs, and other tools, then it will grow.

if circle can handle it, i say we don't touch it right this minute. but for anyone who wants to test it that docker download will be close 15G, no (with FSL and FreeSurfer and AFNI)?

@oesteban
Copy link
Contributor Author

@satra
Copy link
Member

satra commented Feb 16, 2017

don't worry about it right now.

@oesteban
Copy link
Contributor Author

merge?

@satra satra merged commit 5f1c984 into nipy:master Feb 16, 2017
@oesteban oesteban deleted the enh/SortOutDockerfiles branch February 16, 2017 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants