Skip to content

[ENH] Add 3dNotes in AFNI #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 5, 2016
Merged

[ENH] Add 3dNotes in AFNI #1637

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1c27d99
Add AFNI command 3dNotes.
tsalo Sep 8, 2016
d94625b
Merge remote-tracking branch 'nipy/master'
tsalo Sep 15, 2016
497131e
Run make check-before-commit.
tsalo Sep 15, 2016
e545b53
Add IGNORE_UNICODE tag to 3dNotes dockets.
tsalo Sep 15, 2016
e8b0365
Fix single vs. double quotes issue.
tsalo Sep 15, 2016
bb4eae9
Changes quotes in doctest.
tsalo Sep 15, 2016
b077309
Run doctest on correct command.
tsalo Sep 15, 2016
cb41c0e
Run make specs and create functional.HEAD.
tsalo Sep 16, 2016
ee143e8
Switch single and double quotes.
tsalo Sep 16, 2016
c88baff
Replace traits.Str with base Str and switch double/single quotes.
tsalo Sep 16, 2016
54364ec
Merge remote-tracking branch 'nipy/master'
tsalo Oct 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch single and double quotes.
  • Loading branch information
@tsalo
tsalo committed Sep 16, 2016
commit ee143e813bd8f6bdf0e5b3b7c9dfd49182260e86
32 changes: 16 additions & 16 deletions nipype/interfaces/afni/preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3013,26 +3013,26 @@ class QualityIndex(CommandLine):


class NotesInputSpec(AFNICommandInputSpec):
in_file = File(desc='input file to 3dNotes',
argstr='%s',
in_file = File(desc="input file to 3dNotes",
argstr="%s",
position=-1,
mandatory=True,
exists=True,
copyfile=False)
add = traits.Str(desc='note to add',
argstr='-a "%s"')
add_history = traits.Str(desc='note to add to history',
argstr='-h "%s"',
xor=['rep_history'])
rep_history = traits.Str(desc='note with which to replace history',
argstr='-HH "%s"',
xor=['add_history'])
delete = traits.Int(desc='delete note number num',
argstr='-d %d')
ses = traits.Bool(desc='print to stdout the expanded notes',
argstr='-ses')
out_file = File(desc='output image file name',
argstr='%s')
add = traits.Str(desc="note to add",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not use Str from traits:

  1. Add import of Str from nipype.interfaces.base:
    from ..base import (..., Str)
  2. Define these inputs with the imported name:
add = Str(desc...)

argstr="-a '%s'")
add_history = traits.Str(desc="note to add to history",
argstr="-h '%s'",
xor=["rep_history"])
rep_history = traits.Str(desc="note with which to replace history",
argstr="-HH '%s'",
xor=["add_history"])
delete = traits.Int(desc="delete note number num",
argstr="-d %d")
ses = traits.Bool(desc="print to stdout the expanded notes",
argstr="-ses")
out_file = File(desc="output image file name",
argstr="%s")


class Notes(CommandLine):
Expand Down