[ENH] Add 3dNotes in AFNI #1637
Conversation
1. Add 3dNotes to preprocess. It probably belongs in a utils file. 2. Fix typos in QualityIndexOutputSpec and AutoboxOutputSpec. 3. Remove a couple of extra empty lines.
Current coverage is 70.89% (diff: 84.84%)@@ master #1637 diff @@
==========================================
Files 1027 1025 -2
Lines 51574 51562 -12
Methods 0 0
Messages 0 0
Branches 7309 7301 -8
==========================================
- Hits 36564 36553 -11
- Misses 13917 13918 +1
+ Partials 1093 1091 -2
|
|
I think you need to run Also, you probably need to add the test file with |
| mandatory=True, | ||
| exists=True, | ||
| copyfile=False) | ||
| add = traits.Str(desc="note to add", |
There was a problem hiding this comment.
Please, do not use Str from traits:
- Add import of Str from nipype.interfaces.base:
from ..base import (..., Str) - Define these inputs with the imported name:
add = Str(desc...)
| >>> notes.inputs.add = "This note is added." | ||
| >>> notes.inputs.add_history = "This note is added to history." | ||
| >>> notes.cmdline #doctest: +IGNORE_UNICODE | ||
| "3dNotes -a 'This note is added.' -h 'This note is added to history.' functional.HEAD" |
There was a problem hiding this comment.
Result of the interface is not exactly the same, replace by:
'3dNotes -a "This note is added." -h "This note is added to history." functional.HEAD'
| @@ -0,0 +1,2 @@ | |||
| 0.000000 10.000000 1.000000 | |||
There was a problem hiding this comment.
Is this file modified on purpose? Will this modification cause any side effect?
| 0.00495632 -0.00122923 -0.00356384 -0.336943 0.338448 -0.465876 | ||
| 0.00498272 -0.0012813 -0.00356384 -0.319189 0.338466 -0.465136 | ||
| 0.00548257 -0.00133825 -0.00385146 -0.335071 0.296729 -0.468606 | ||
| -0.00848102 0.00369798 0.003424 0.31043 -0.751705 0.619666 |
There was a problem hiding this comment.
Why this file is modified?
| 0.048314 | ||
| 0.0224355 | ||
| 0.10331 | ||
| 0.0922165 |
There was a problem hiding this comment.
Why this file is modified?
There was a problem hiding this comment.
These files were modified when I ran make check-before-commit. Since they were automatically generated by the tool, I assumed it served a purpose, but I can't be sure.
There was a problem hiding this comment.
I see, let me fix that in current master. That way we keep your PR clean
Also re-run make check-before-commit, which overwrote the old 3dNotes test.
|
Is there anything else I need to do? Also, is Str preferred over traits.Str for all inputs? |
|
Hi @tsalo, it's been impossible for me to come back to you before. I updated master so your PR would be clean of unrelated changes from check-before-commit. Sorry for this inconvenience, master in nipype is usually pretty active and lately it's been through a bit bumpy road. May you please merge with current master? Thanks very much. |
No description provided.