EHN: Improve JSON interfaces #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| if force_run: | ||
| self._always_run = True | ||
|
|
||
| def _process_name(self, name, val): |
There was a problem hiding this comment.
hi @satra, thinking about the [string[.[@]string]] format, I guess there's no use for the @ here right? I've implemented only the dot element to create nested dictionaries
There was a problem hiding this comment.
the @ in datasink allows people to dump multiple outputs to the same location and that nipype won't allow connecting two different outputs to the same input.
i'm not sure yet of all the use cases for this interface, but perhaps we can implement it later if needed.
There was a problem hiding this comment.
+1 on implementing it later, let's see what happens when people use this
2 tasks
|
@oesteban - sync with master and update changes for merge. feel free to merge this. |
Conflicts: CHANGES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1020, the idea of this PR is improving these new interfaces.
defaultsinput toJSONFileGrabberso that one can set default settings to workflows in case the JSON file with settings does not exist.JSONFileSinkoutputs, as @satra suggested in ENH: IO interfaces to JSON files #1020 or maybe with a novel paradigm.