-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: improve sdc_fmb (fieldmap-based susceptibility distortion correction) #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've submitted PR #1020 . If this was accepted, I will include a JSONFileGrabber interface to read parameters from a file in execution time, instead of hard-setting them as arguments of the workflow's creation function. I also edit the original tasks list. |
Conflicts: CHANGES
Conflicts: CHANGES
This PR is ready for review |
fmm2b0.inputs.winsorize_upper_quantile = 0.995 | ||
|
||
applyxfm = pe.Node(ants.ApplyTransforms( | ||
dimension=3, interpolation='BSpline'), name='FMp_to_B0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BSpline
gave me a whole lot of trouble on non-negative variance images (and appears to be an ITK issue). so make sure that this works here. otherwise you may want to go with Linear
. it will make the field smoother, but may not be that big an issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree, let's go with Linear
by default.
Conflicts: CHANGES
@satra, may I merge this? I will need it in the future, I still have the idea of revise all the distortion correction framework we are building. |
@oesteban - i would request a change of name before the merge, but feel free to merge after the name change. as implemented this looks specific to diffusion rather than any epi images, so you may want to change the name. for general application to epi images: perhaps using an index to focus on a set of images for getting the mean image. the index would be b0 images for diffusion and could be all images for other functional paradigms. |
you are right, that's the only difference between dmri and fmri. I will see how to cover all the cases. If the workflow worked for both families of epi images, would the name be appropriate? |
yes |
Now there is no |
ENH: improve sdc_fmb (fieldmap-based susceptibility distortion correction)
sdc_fmb