Skip to content

ENH: improve sdc_fmb (fieldmap-based susceptibility distortion correction) #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 23, 2015

Conversation

oesteban
Copy link
Contributor

@oesteban
Copy link
Contributor Author

I've submitted PR #1020 . If this was accepted, I will include a JSONFileGrabber interface to read parameters from a file in execution time, instead of hard-setting them as arguments of the workflow's creation function. I also edit the original tasks list.

@oesteban
Copy link
Contributor Author

This PR is ready for review

fmm2b0.inputs.winsorize_upper_quantile = 0.995

applyxfm = pe.Node(ants.ApplyTransforms(
dimension=3, interpolation='BSpline'), name='FMp_to_B0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSpline gave me a whole lot of trouble on non-negative variance images (and appears to be an ITK issue). so make sure that this works here. otherwise you may want to go with Linear. it will make the field smoother, but may not be that big an issue here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, let's go with Linear by default.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 70.76% when pulling a15cbc6 on oesteban:enh/AntsForFMBworkflow into 453bcf9 on nipy:master.

@oesteban
Copy link
Contributor Author

@satra, may I merge this? I will need it in the future, I still have the idea of revise all the distortion correction framework we are building.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 70.76% when pulling dc36fc9 on oesteban:enh/AntsForFMBworkflow into 5e05ffe on nipy:master.

@satra
Copy link
Member

satra commented Mar 20, 2015

@oesteban - i would request a change of name before the merge, but feel free to merge after the name change. as implemented this looks specific to diffusion rather than any epi images, so you may want to change the name.

for general application to epi images: perhaps using an index to focus on a set of images for getting the mean image. the index would be b0 images for diffusion and could be all images for other functional paradigms.

@oesteban
Copy link
Contributor Author

you are right, that's the only difference between dmri and fmri. I will see how to cover all the cases. If the workflow worked for both families of epi images, would the name be appropriate?

@satra
Copy link
Member

satra commented Mar 20, 2015

yes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.79% when pulling fc0d9bb on oesteban:enh/AntsForFMBworkflow into 5e05ffe on nipy:master.

@oesteban
Copy link
Contributor Author

Now there is no in_bval input, being replaced by in_ref a list of indices of the images to be averaged as baseline.

oesteban added a commit that referenced this pull request Mar 23, 2015
ENH: improve sdc_fmb (fieldmap-based susceptibility distortion correction)
@oesteban oesteban merged commit 48eb213 into nipy:master Mar 23, 2015
@oesteban oesteban deleted the enh/AntsForFMBworkflow branch March 23, 2015 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants