RF(+BF somewhat): remove no longer needed dependencies etc

[yarikoptic]

Ran into it while testing neurodebian package for 0.8.0 -- ran into:

$> docker run -it --rm reproin-test-0.8.0:latest --help
Traceback (most recent call last):
  File "/usr/bin/heudiconv", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 3191, in <module>
    @_call_aside
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 3175, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 3204, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'pathlib' distribution was not found and is required by heudiconv

because info.py claims it as a dependency, and there were no pip install which would have pulled it from pypi (even though it is included in python itself)

[codecov]

Codecov Report

Merging #443 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files          35       35           
  Lines        2863     2863           
=======================================
  Hits         2147     2147           
  Misses        716      716           

Impacted Files	Coverage Δ
heudiconv/info.py	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a7cb5...672d3a3. Read the comment docs.

[caldodge]

This is actually a major issue for heudiconv, since it requires features that exist in the built-in pathlib, but not the version installed via pip. For example, the package version does not allow "exist_ok" as a parameter to "mkdir" in a Path object.

[yarikoptic]

why would you install pathlib via pip if it is now included in the standard library and thus most likely pypi version is just outdated (last updated in 2014)?

[caldodge]

I did not explicitly install pathlib. Since heudiconv 0.8.0 (installed via pip) lists pathlib as a requirement, PIP installed it. I had to remove it, remove pathlib references from the relevant locations, then reinstall it to eliminate the problem. So apparently I can't trust whoever maintains heudiconv on pypi to have the latest version.

…

On Fri, Oct 9, 2020 at 7:29 PM Yaroslav Halchenko ***@***.***> wrote: why would you install pathlib via pip if it is now included in the standard library and thus most likely pypi version is just outdated (last updated in 2014)? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWSED7KDRESOG2LGCTIWELSJ6TFRANCNFSM4MMTHEOA> .

[yarikoptic]

;-) it does have the latest version! it is just those (same) people just need to release heudiconv 0.8.1...

but the point here is that actually it should have been pathlib pypi maintainers which probably should have made it impossible to install pathlib for versions of python where it was already included.But let's get back to

This is actually a major issue for heudiconv, since it requires features that exist in the built-in pathlib, but not the version installed via pip. For example, the package version does not allow "exist_ok" as a parameter to "mkdir" in a Path object.

(git)lena:~/picts/mris/heudiconv-master[master]git
$> git describe
v0.8.0-68-gd855f64
$> git grep exist_ok
$>

do you have more specific pointer of what feature of bundled pathlib we are using which is not present in pypi's?

[caldodge]

Certainly. mkdir in the built-in pathlib allows the parameter "exist_ok". The version in the pathlib package does not. This was how we discovered it, as a user who was trying out heudiconv received multiple messages that mkdir didn't understand "exist_ok".

…

On Sat, Oct 10, 2020 at 6:45 PM Yaroslav Halchenko ***@***.***> wrote: ;-) it does have the latest version! it is just those (same) people just need to release heudiconv 0.8.1... but the point here is that actually it should have been pathlib pypi maintainers which probably should have made it impossible to install pathlib for versions of python where it was already included.But let's get back to This is actually a major issue for heudiconv, since it requires features that exist in the built-in pathlib, but not the version installed via pip. For example, the package version does not allow "exist_ok" as a parameter to "mkdir" in a Path object. (git)lena:~/picts/mris/heudiconv-master[master]git $> git describe v0.8.0-68-gd855f64 $> git grep exist_ok $> do you have more specific pointer of what feature of bundled pathlib we are using which is not present in pypi's? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEWSEDYVXWMZ2K67FSRXLL3SKDW2BANCNFSM4MMTHEOA> .