-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test minimum dependencies #96
CI: Test minimum dependencies #96
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
Hello @effigies, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-11-18 18:20:48 UTC |
710e416
to
ec59db0
Compare
@oesteban This is failing with nipype 1.3.1 and traits 6.0.0. The issue was fixed in 1.4.2 (nipy/nipype#3159). Not sure what the best way to handle sudden API breakages in packages a couple levels upstream would be. It might be that testing minimum dependencies in a package with this big a dependency tree is just not feasible. |
Yeah, I don't have an answer to that either. What do you feel would be the best course of action on this matter, at this point? |
ce3475e
to
e838ad9
Compare
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=========================================
Coverage ? 49.58%
=========================================
Files ? 14
Lines ? 968
Branches ? 118
=========================================
Hits ? 480
Misses ? 474
Partials ? 14
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ef7d812
to
5b50bc0
Compare
5b50bc0
to
553a806
Compare
This PR, amongst other things, has triggered the combo d01d882, 01c8188 (which means, has made me revise all the dependencies) - so it is a good thing to merge asap. Iterating over this, we can try to expand this base to follow up dependencies of niworkflows, nipype, pybids and templateflow. Including something like that, we should be in acceptable shape. |
2.0.0rc4 * FIX: Convert SEI fieldmaps given in rad/s into Hz (#127) * FIX: Limit ``3dQwarp`` to maximum 4 CPUs for stability reasons (#128) * ENH: Generate a simple mask after correction (#161) * ENH: Increase unit-tests coverage of ``sdcflows.fieldmaps`` (#159) * ENH: Optimize tensor-product B-Spline kernel evaluation (#157) * ENH: Add a memory check to dynamically limit interpolation blocksize (#156) * ENH: Massage TOPUP's fieldcoeff files to be compatible with ours (#154) * ENH: Add a simplistic EPI masking algorithm (#152) * ENH: Utility that returns the ``B0FieldSource`` of a given potential EPI target (#151) * ENH: Write ``fmapid-`` entity in Derivatives (#150) * ENH: Multiplex fieldmap estimation outputs into a single ``outputnode`` (#149) * ENH: Putting the new API together on a base workflow (#143) * ENH: Autogenerate ``B0FieldIdentifiers`` from ``IntendedFor`` (#142) * ENH: Finalizing the API overhaul (#132) * ENH: Keep a registry of already-used identifiers (and auto-generate new) (#130) * ENH: New objects for better representation of fieldmap estimation (#114) * ENH: Show FieldmapReportlet oriented aligned with cardinal axes (#120) * ENH: New estimation API (featuring a TOPUP implementation!) (#115) * DOC: Minor improvements to the literate workflows descriptions. (#162) * DOC: Fix typo in docstring (#155) * DOC: Enable NiPype's sphinx-extension to better render Interfaces (#131) * MAINT: Drop Python 3.6 (#160) * MAINT: Enable Git-archive protocol with setuptools-scm-archive (#153) * MAINT: Migrate TravisCI -> GH Actions (completion) (#138) * MAINT: Migrate TravisCI -> GH Actions (#137) * MAINT: Minimal unit test and refactor of pepolar workflow node (#133) * MAINT: Collect code coverage from tests on Circle (#122) * MAINT: Test minimum dependencies with TravisCI (#96) * MAINT: Add FLIRT config files to prepare for TOPUP integration (#116)
This sets up Travis to test minimum dependencies. I don't have permissions to turn on Travis for SDCflows.