-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Keep a registry of already-used identifiers (and auto-generate new) #130
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/1.4.0 #130 +/- ##
=============================================
+ Coverage 88.44% 88.55% +0.10%
=============================================
Files 15 15
Lines 926 952 +26
Branches 109 120 +11
=============================================
+ Hits 819 843 +24
- Misses 75 76 +1
- Partials 32 33 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0b31473
to
5fee784
Compare
Okay, I think this PR would be the most interesting part of the big refactor I'm undertaking on It also starts with the implementation of the I think this tracking helps justify the utilization of the Thoughts? |
Okay, I'm going to continue with the overhaul - sorry for not allowing the adequate review window to properly eyeball through all the changes. |
2.0.0rc4 * FIX: Convert SEI fieldmaps given in rad/s into Hz (#127) * FIX: Limit ``3dQwarp`` to maximum 4 CPUs for stability reasons (#128) * ENH: Generate a simple mask after correction (#161) * ENH: Increase unit-tests coverage of ``sdcflows.fieldmaps`` (#159) * ENH: Optimize tensor-product B-Spline kernel evaluation (#157) * ENH: Add a memory check to dynamically limit interpolation blocksize (#156) * ENH: Massage TOPUP's fieldcoeff files to be compatible with ours (#154) * ENH: Add a simplistic EPI masking algorithm (#152) * ENH: Utility that returns the ``B0FieldSource`` of a given potential EPI target (#151) * ENH: Write ``fmapid-`` entity in Derivatives (#150) * ENH: Multiplex fieldmap estimation outputs into a single ``outputnode`` (#149) * ENH: Putting the new API together on a base workflow (#143) * ENH: Autogenerate ``B0FieldIdentifiers`` from ``IntendedFor`` (#142) * ENH: Finalizing the API overhaul (#132) * ENH: Keep a registry of already-used identifiers (and auto-generate new) (#130) * ENH: New objects for better representation of fieldmap estimation (#114) * ENH: Show FieldmapReportlet oriented aligned with cardinal axes (#120) * ENH: New estimation API (featuring a TOPUP implementation!) (#115) * DOC: Minor improvements to the literate workflows descriptions. (#162) * DOC: Fix typo in docstring (#155) * DOC: Enable NiPype's sphinx-extension to better render Interfaces (#131) * MAINT: Drop Python 3.6 (#160) * MAINT: Enable Git-archive protocol with setuptools-scm-archive (#153) * MAINT: Migrate TravisCI -> GH Actions (completion) (#138) * MAINT: Migrate TravisCI -> GH Actions (#137) * MAINT: Minimal unit test and refactor of pepolar workflow node (#133) * MAINT: Collect code coverage from tests on Circle (#122) * MAINT: Test minimum dependencies with TravisCI (#96) * MAINT: Add FLIRT config files to prepare for TOPUP integration (#116)
This is the projection of the
B0FieldIdentifier
metadata proposed for the BIDS spec. Having an identifier for each estimation strategy is the most robust way of minimizing the computational load and reliably keep track of fieldmap information.Followed-up-by: #129.
Resolves: #125.