FIX: Re-enable priors respecting sd_priors argument

[oesteban]

Re-enables the inclusion of a prior mask, but moving the logic into the preprocessing (which is more readable).

If sd_priors is set to False on the preprocessing, then the sd_prior output is populated with another brain mask (which is equivalent to the behavior after #480).

EDIT: Pun intended for @effigies. As you'll see, I've refrained from changing the argument name atlas_threshold, however, I fixed the node name because—to me—a displacements field is not an atlas :D

[effigies]

This makes sense to me.

@mgxd Note that sd_prior is removed from the syn_sdc_wf. It never did anything, but you should stop passing it before we remove **kwargs (if we do). It does still do something on the syn_preprocessing_wf.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (986d7fd) to head (290d240).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   83.86%   83.98%   +0.11%     
==========================================
  Files          30       30              
  Lines        2826     2828       +2     
  Branches      367      367              
==========================================
+ Hits         2370     2375       +5     
+ Misses        385      384       -1     
+ Partials       71       69       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[oesteban]

This makes sense to me.

and the atlas pun? 😅

EDIT: I see your emoji reaction now :D

[mgxd]

Have not tested it, but feels cleaner removing the priors logic within init_syn_sdc_wf.