Skip to content

ENH: Allow changing laplacians weights in SyN registration metric #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

oesteban
Copy link
Member

No description provided.

@oesteban oesteban requested review from effigies and mgxd March 26, 2025 14:23
@oesteban oesteban enabled auto-merge March 26, 2025 14:23
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.88%. Comparing base (fd8220d) to head (9371efd).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
sdcflows/workflows/fit/syn.py 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   83.84%   73.88%   -9.96%     
==========================================
  Files          30       30              
  Lines        2822     2826       +4     
  Branches      366      291      -75     
==========================================
- Hits         2366     2088     -278     
- Misses        385      645     +260     
- Partials       71       93      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. A quick test to generate the workflow with 0, 0.5 and 1 and check the values in wf.inputs.syn.metric_weight (I think that wokrs) would be useful.

@oesteban oesteban merged commit d61a4ef into master Mar 26, 2025
4 of 17 checks passed
@oesteban oesteban deleted the enh/syn-laplacian-weight branch March 26, 2025 14:34
effigies added a commit that referenced this pull request May 15, 2025
2.13.0 (May 15, 2025)

Feature release in the 2.13.x series.

This release addresses some longstanding issues with the SyN-SDC workflow,
improving the registration quality in adult humans by utilizing a spatial prior,
as well as allowing Laplacians to be up- or down-weighted in the cost function,
making it more usable across species.

Additionally, this release allows for the use of ``EstimatedTotalReadoutTime`` or
``EstimatedEchoSpacing``, or a manually provided fallback ``TotalReadoutTime`` value,
permitting the use of SDCFlows on datasets that do not have reliable timing information
without introducing incorrect metadata into the datasets.

* fix(syn): Re-enable priors respecting ``sd_priors`` argument (#488)
* feat: Add workflow arguments for metadata estimates and fallback TRT (#479)
* feat(syn): Update totalFieldVarianceInVoxel space based on voxel resolution (#487)
* feat(syn): Allow changing laplacians weights in SyN registration metric (#484)
* test(syn): Add a test to exercise SyN workflow creation and check parameters (#486)
effigies added a commit that referenced this pull request May 15, 2025
2.13.0 (May 15, 2025)

Feature release in the 2.13.x series.

This release addresses some longstanding issues with the SyN-SDC workflow,
improving the registration quality in adult humans by utilizing a spatial prior,
as well as allowing Laplacians to be up- or down-weighted in the cost function,
making it more usable across species.

Additionally, this release allows for the use of ``EstimatedTotalReadoutTime`` or
``EstimatedEchoSpacing``, or a manually provided fallback ``TotalReadoutTime`` value,
permitting the use of SDCFlows on datasets that do not have reliable timing information
without introducing incorrect metadata into the datasets.

* fix(syn): Re-enable priors respecting ``sd_priors`` argument (#488)
* feat: Add workflow arguments for metadata estimates and fallback TRT (#479)
* feat(syn): Update totalFieldVarianceInVoxel space based on voxel resolution (#487)
* feat(syn): Allow changing laplacians weights in SyN registration metric (#484)
* test(syn): Add a test to exercise SyN workflow creation and check parameters (#486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants