Flip order of transforms in init_ds_volumes_wf
#3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there's an unrelated style issue. |
|
Could you rebase onto |
tsalo
force-pushed
the
fix-xform-application
branch
from
43f1296
to
547fc25
Compare
effigies
force-pushed
the
fix-xform-application
branch
from
547fc25
to
2cfdf34
Compare
|
@effigies thank you for fixing the terrible thing I did |
effigies
reviewed
Feb 29, 2024
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint/23.2.x #3238 +/- ##
================================================
- Coverage 72.41% 72.36% -0.05%
================================================
Files 55 55
Lines 4103 4103
================================================
- Hits 2971 2969 -2
- Misses 1132 1134 +2 ☔ View full report in Codecov by Sentry. |
effigies
added a commit
that referenced
this pull request
Mar 6, 2024
23.2.1 (March 06, 2024) Bug fix release in the 23.2.x series. Masks, BOLD references and T2\* maps resampled into template spaces had their order of transforms inverted. BOLD files were unaffected. This release also preserves the TR in the NIfTI header of BOLD series. * FIX: Preserve pixdim4+ of resampled images (#3239) * FIX: Flip order of transforms in ``init_ds_volumes_wf`` (#3238) * DOCKER: restore mincinfo binary (#3249) * CI: Move to new CircleCI machine tags (#3247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3237.
Changes proposed in this pull request
boldref2targetnode ofinit_ds_volumes_wffrom boldref2anat_xfm --> anat2std_xfm to anat2std_xfm --> boldref2anat_xfm, as antsApplyTransforms expects transforms to be provided in reverse order.Documentation that should be reviewed
none