Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product name for Carthage #252

Merged
merged 1 commit into from
Dec 29, 2018
Merged

Fix product name for Carthage #252

merged 1 commit into from
Dec 29, 2018

Conversation

ninjaprox
Copy link
Owner

Address #251.

@ninjaprox ninjaprox merged commit 8c4b291 into master Dec 29, 2018
@ninjaprox ninjaprox deleted the fix-carthage branch December 29, 2018 14:12
@intoxicated
Copy link

I wonder why would we need to have two different names for the same framework?..

@ninjaprox
Copy link
Owner Author

@intoxicated: There're 3 targets so it'll result 3 frameworks, and each has different name to differentiate the another one.

@ninjaprox
Copy link
Owner Author

@intoxicated: The ongoing discussion regarding your question is on #259. It turns out that they all can have the same name, and it'll be fixed in the upcoming release.

@ninjaprox ninjaprox mentioned this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants