Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build project with Carthage #251

Closed
miharancic opened this issue Dec 27, 2018 · 5 comments
Closed

Unable to build project with Carthage #251

miharancic opened this issue Dec 27, 2018 · 5 comments

Comments

@miharancic
Copy link

After Carthage update / bootstrap version 4.5.0 is downloaded and built, Carthage doesn't report any problems. But during project build I get an error "No such module NVActivityIndicatorView". I am using import NVActivityIndicatorView from the beginning. After Carthage update, Xcode completion suggests I should import "NVActivityIndicatorView_iOS" but still can't build with the same error message ("No such module NVActivityIndicatorView_iOS").

I have been using NVActivityIndicatorView for over a year with no problems... until now.

Could you please investigate?

Thanks

@joshuapoq
Copy link

joshuapoq commented Dec 28, 2018

Found the same issue - we just need to change the product module name of the -iOS target.

@ninjaprox
Copy link
Owner

Sorry for the issue, this is probably due to the recent change of the target name in version 4.5.0. 4.5.1 has been out to address this issue with one caveat of changing to import NVActivityIndicatorView_iOS (README updated).

Please help verify the fix.

@miharancic
Copy link
Author

Fix verified, everything working as expected. Thank you and keep up the good work :)

@ninjaprox
Copy link
Owner

The ongoing discussion regarding the matter is on #259. Please expect the change in the upcoming release, which will revert back to import NVActivityIndicatorView. Sorry for this inconvenience.

@ninjaprox
Copy link
Owner

Now with 4.6.0, you can simply import NVActivityIndicatorView as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants