document partial generics breaking changes, add auto convenience
#24051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nobody asked for this feature though. Better just document the breaking change. |
|
Opened separate PR for changelog to keep this as proof of concept: #24055 |
Araq
pushed a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #24010, refs c-blake/cligen#233 (comment)
The breaking changes from #24010 regarding partial generic instantiation of routines no longer being allowed are now added to the changelog.
A convenience has also been added as an experimental feature of using
autoin place of parameters that can be inferred in routine generic instantiations, for when the types are too complex to type normally. An example of where this would be useful is the PR to combparser that was needed for #24010. Unfortunately it wouldn't work in an older version so one would have to use awhenversion check to useautoin new versions and partial instantiation in old versions.