Skip to content

fix for nim 2.2, provide all generic params when instantiating Nothing #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix for nim 2.2, provide all generic params when instantiating Nothing #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/combparser.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ proc flatMap*[T, U, V](parser: Parser[T, V], f: (proc(value: T): Parser[U, V])):
Something(ret, xresult, "flatMap operation", input)
return ret
else:
let ret = Nothing[(U, string)](xresult, "Unable to flat-map onto bad output", input)
let ret = Nothing[(U, string), (T, V), V](xresult, "Unable to flat-map onto bad output", input)
return ret
)

Expand All @@ -375,7 +375,7 @@ proc chainl*[T, U](p: Parser[T, U], q: Parser[(proc(a: T, b: T): T), U], allowEm
first = p(input)
(firstVal, rest) = first.value
if not first.hasValue:
return Nothing[(T, U), (T, U)](first, "Chainl operation failed: First value not matching", input)
return Nothing[(T, U), (T, U), U](first, "Chainl operation failed: First value not matching", input)
if rest.len == 0:
return first
var ret = (q + p).repeat(if allowEmpty: 0 else: 1).map(proc(values: seq[((proc(a: T, b: T): T), T)]): T =
Expand Down