improve nimsuggest/tester, minor improvements to koch.nim #17879
+24
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
changed the title
timotheecour
commented
Apr 28, 2021
|
|
||
| proc parseTest(filename: string; epcMode=false): Test = | ||
| const cursorMarker = "#[!]#" | ||
| let nimsug = curDir & addFileExt("nimsuggest", ExeExt) |
Member
Author
There was a problem hiding this comment.
previous code was picking up the nimsuggest in PATH instead of the one in bin/nimsuggest that was just built in runCI; for CI it doesn't matter since there's only one, but it matters when testing and user has installed nim prior to running this. If needed i can add an option to pass nimsuggest binary via --nimsuggest:exe
new behavior is more consistent with how we test other tools
timotheecour
commented
Apr 28, 2021
| inp.writeLine("quit") | ||
| inp.flush() | ||
| except: | ||
| except IOError, OSError: |
timotheecour
commented
Apr 28, 2021
| disabled: bool | ||
|
|
||
| const | ||
| curDir = when defined(windows): "" else: "" |
Member
Author
There was a problem hiding this comment.
made no sense; and empty string should not mean cwd
timotheecour
added
the
Ready For Review
timotheecour
removed
the
Ready For Review
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
…7879) * improve nimsuggest/tester * koch improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
further diffs factored out from #17865 to keep the more tricky PR clean of unrelated changes