nim check: make error msgs less redundant #17865
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve Example 3 from #16178
XDG_CONFIG_HOME= nim check --spellsuggest:0 --hints:off --filenames:canonical $timn_D/tests/nim/all/t12213.nimbefore PR
after PR
note
if you have a concrete idea for how to avoid
when defined(nimsuggest): ...I'm all ears, otherwise the change is good enough for nowfuture work
errorSubNodeornewError(which uses the newnkError) instead oferrorNode(which usesnkEmpty) so that we can also remove the 2nd and 3rd line; as explained in PR; this is a bigger change so can be done in future work (it's already hard enough because it interferes with nimsuggest)