Conversation
- Change the port on API.cljs - Recompile the assets
* Rename RoomChannel to GameChannel and make it room sensitive * Refactor exists? -> presence * Add basic host game state * Pull out high-level coordination stuff in a stateless Game module * Add functions to update host & participants on Game * Hook up game state updates with controller * Make game channel check for presence of game * Refactor Game-related modules * Better controller-layer error handling * Just pull the room name from join params instead of socket * Specify imported functions from ControllerHelpers
|
Why is this a single PR? |
Contributor
Author
Because I want to avoid the trouble of creating PRs for daily updates until we reach The I'll only make separate PRs for significant Elixir/Phoenix changes. |
* Add CI via github actions * Add a compilation step * Add postgres service to run tests in github workflow * Add configuration for running tests on the CI * Fix: The postgres_host configuration while running the tests in CI * Fix: Incorrect assertions in the error view tests * Add CI status badge
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged to
masteronce we're happy with the alpha-mvp.