Merged
Conversation
yudistrange
previously requested changes
May 31, 2020
Contributor
yudistrange
left a comment
yudistrange
left a comment
There was a problem hiding this comment.
Not sure if the change in the router module was responsible for the MIME error you were facing.
But other than that, the changes look good for a merge.
| end | ||
|
|
||
| scope "/", PencilSpaceServerWeb do | ||
| pipe_through :api |
Contributor
There was a problem hiding this comment.
This should be :browser instead of :api
| use PencilSpaceServerWeb, :controller | ||
| alias PencilSpaceServer.{GameMonitor} | ||
| alias PencilSpaceServer.Game | ||
| import PencilSpaceServerWeb.ControllerHelpers |
Contributor
There was a problem hiding this comment.
MINOR: You can also specify the functions that are being imported from this module.
https://elixir-lang.org/getting-started/alias-require-and-import.html#import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening this PR over #4 because we renamed the base branch from cljs to alpha.