Skip to content

Conversation

@Andries-Smit
Copy link
Contributor

@Andries-Smit Andries-Smit commented Jan 27, 2022

The carb dialog allows a user to enter an offset in minutes, and an event time through the date/time picker. This gave an inconsistent UI
Where it was possible to change both.

The expected behaviour;

  1. When the Offset time is changed, the Event time is updated.
  2. When the Event time date is changed the Offset time is updated.
  3. When the Event time time is changed the Offset time is updated.
  4. The + and - 12 hours limit set through the Offset time will be enforced on the Event time too, working together with PR Fix/number picker set limit #1233

Note: no side effects are expected on the other dialogs that are using the DialogFragmentWithDate in combination with Number/Minute picker.

  • Additional I made the insulin dialog with the "Do not bolus, record only" option to use the minutes picker too

image

@Andries-Smit Andries-Smit force-pushed the fix/carbs-event-time branch 4 times, most recently from 13e3b00 to 2705f30 Compare January 27, 2022 20:57
@MilosKozak MilosKozak merged commit 65eb96a into nightscout:dev Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants