Fix/number picker set limit #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the Insulin dialog, and Carb dialog, are quick buttons to add x amount; this helps users to enter the values more quickly. When the value is larger than the max, the toast is shown, and the OK button is disabled.
Expected behavior implemented in the PR; similar to the number picker + and - button, is to set the value to the max, show the toast and therefore keep the OK button enabled.
The only one case where the OK buttons will disable when the user enters a value larger than the max with keyboard is it best practice to validate keyboard input and not overwrite them